Conversation
yasserahmed10
added
enhancement
Test Results355 tests +14 318 ✅ +14 10s ⏱️ ±0s For more details on these failures, see this check. Results for commit 521bc3f. ± Comparison against base commit 6ee1efc. This pull request removes 19 and adds 32 tests. Note that renamed tests count towards both. |
|
❌ Test or Coverage checks failed! Please check the workflow run for details. |
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/qodana-action@v2024.3.4
with:
upload-result: trueContact Qodana teamContact us at qodana-support@jetbrains.com
|
aabukmail
approved these changes
May 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several new test cases and updates to improve test coverage and maintainability across the codebase. The changes include adding unit tests for subtask-related use cases, renaming a test class for consistency, and enhancing the
MapperKtTestto cover additional scenarios.New test cases for subtask-related use cases:
CreateSubTaskUseCaseTestto verify the creation of subtasks, including success, failure, and validation of the passedSubTaskobject. (src/test/kotlin/domain/usecases/sub_task/CreateSubTaskUseCaseTest.kt)DeleteSubTaskUseCaseTestto test the deletion of subtasks, ensuring correct behavior when the repository succeeds or fails, and validating the passed subtask ID. (src/test/kotlin/domain/usecases/sub_task/DeleteSubTaskUseCaseTest.kt)GetSubTasksByTaskIdUseCaseTestto test fetching subtasks by task ID, covering scenarios where the repository returns data, no data, and validating the task ID passed to the repository. (src/test/kotlin/domain/usecases/sub_task/GetSubTasksByTaskIdUseCaseTest.kt)UpdateSubTaskUseCaseTestto validate the update functionality for subtasks, including success, failure, and ensuring the correctSubTaskobject is passed to the repository. (src/test/kotlin/domain/usecases/sub_task/UpdateSubTaskUseCaseTest.kt)Enhancements to existing tests:
MapperKtTestby adding tests for converting aStringto aSubTaskand converting aTaskDtoto aTaskwith subtasks, improving coverage for mapping logic. (src/test/kotlin/data/mappers/MapperKtTest.kt)Test class renaming for consistency:
TaskStateDataSourceImplTesttoTaskStateRepositoryImplTestto align with the updated naming conventions of the repository layer. (src/test/kotlin/data/repositories/TaskStateRepositoryImplTest.kt)